Closed Bug 1024196 Opened 11 years ago Closed 11 years ago

CreateGrGLInterfaceFromGLContext leaks |i| when extensions.init fails

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: mccr8, Assigned: wlitwinczyk, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, memory-leak, Whiteboard: [MemShrink:P3][CID 1195354])

Attachments

(1 file, 1 obsolete file)

skia_bug_1024196
1022 bytes, patch
gw280
: review+
Details | Diff | Splinter Review
GrGLInterface* i = new GrGLInterface(); ... if (!extensions.init(i->fStandard, glGetString_mozilla, NULL, glGetIntegerv_mozilla)) { // leak of i return nullptr; }
Whiteboard: [MemShrink] → [MemShrink][CID 1195354]
Whiteboard: [MemShrink][CID 1195354] → [MemShrink:P3][CID 1195354]
Mentor: continuation
Assignee: nobody → wlitwinczyk
Attached patch skia_bug_1024196 (obsolete) — — Splinter Review
Hi Andrew, Would you mind checking if this patch fixes the leak?
Flags: needinfo?(continuation)
Flags: needinfo?(continuation)
Looks reasonable to me, though I have no way of checking until this lands. :)
Attachment #8453194 - Flags: review?(gwright)
Attachment #8453194 - Flags: review?(gwright)
Attached patch skia_bug_1024196 — — Splinter Review
Attachment #8453194 - Attachment is obsolete: true
Attachment #8453315 - Flags: review?(gwright)
Attachment #8453315 - Flags: review?(gwright) → review+
https://hg.mozilla.org/mozilla-central/rev/7c238ae102ab
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: